BUG: add missing sdf files to CMakeLists #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapulina
approved these changes
Jul 23, 2021
|
Already on it. Also want to double-check if these files exist in earlier versions and if they were forgotten there, too. |
Closes: gazebosim#629 Signed-off-by: Sebastian Wallkötter <[email protected]>
Signed-off-by: FirefoxMetzger <[email protected]> Signed-off-by: Sebastian Wallkötter <[email protected]>
Signed-off-by: FirefoxMetzger <[email protected]> Signed-off-by: Sebastian Wallkötter <[email protected]>
|
Interesting DCO policy. Github picks up signed-off commits based on the username and shows the (Verified) tag next to the commit, but apparently the test requires the real name, which then no longer gets picked up by GitHub . . . In any case, @chapulina The files were missing up to v1.6 where they were introduced. I simply added them too all CMakeLists involved. |
chapulina
approved these changes
Jul 23, 2021
Signed-off-by: Sebastian Wallkötter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #629
Summary
Adds the missing sdf files to CMakeLists in v1.8.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge