Fix ABI break on sdf11 #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
adlarkin
approved these changes
Jun 28, 2021
Signed-off-by: Addisu Z. Taddese <[email protected]>
scpeters
approved these changes
Jun 29, 2021
|
@osrf-jenkins run tests, you're good to go now |
|
I enabled the DCO bot after this PR was open. Let's merge without that check for now, reopening the PR would trigger lots of builds. |
chapulina
added a commit
that referenced
this pull request
Jun 30, 2021
* Add triage, remove ticket templates (#608) Signed-off-by: Louise Poubel <[email protected]> * Fix ABI break on sdf11 (#606) Signed-off-by: Addisu Z. Taddese <[email protected]> * 🎈 11.2.1 (#609) Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Steve Peters <[email protected]> * Fix segfault when checking for required elements in joint (#610) * Used xml instead of elemXml, added test for this particular case Signed-off-by: Aaron Chong <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: Aaron Chong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Similar to #605, but with additional changes for the sdf11 branch. The recently added members to
sdf::ElementPrivateareexplicitlySetInFile,lineNumber, andxmlPath(sdformat11_11.1.0...sdformat11_11.2.0)Checklist
sh tools/code_check.sh)test coverage)
another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge