Fix ABI break #605
Merged
Fix ABI break #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the recently added data member `explicitlySetInFile` to the end of the `ElementPrivate` class Signed-off-by: Addisu Z. Taddese <[email protected]>
adlarkin
approved these changes
Jun 28, 2021
chapulina
approved these changes
Jun 28, 2021
|
@osrf-jenkins run tests please |
|
That variable was added in #542, which hasn't been released into |
scpeters
approved these changes
Jun 29, 2021
|
@osrf-jenkins run tests you can |
|
I enabled the DCO bot after this PR was open. Let's merge without that check for now, reopening the PR would trigger lots of builds. |
jennuine
pushed a commit
that referenced
this pull request
Jul 29, 2021
This moves the recently added data member `explicitlySetInFile` to the end of the `ElementPrivate` class Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Jenn Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
This moves the recently added data member
explicitlySetInFileto theend of the
ElementPrivateclass to an ABI breakage (See gazebosim/gz-sim#891).We are using the Pimpl pattern with the
Elementclass to avoid ABI issues, however, we have template functions that use data members from theElementPrivateclass inElement.hh. These templates can get instantiated in a translation unit outside of the ones used to buildlibsdformatand the offset values for the data members be computed based on the order of the members at the time the translation unit is compiled. When we later change the order of the data members, the offsets in the translation units will become invalid causing a crash as seen in gazebosim/gz-sim#891Checklist
sh tools/code_check.sh)test coverage)
another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge