Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focal CI: static checkers and doxygen linters #298

Merged
merged 4 commits into from
Mar 14, 2022

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Add cppcheck, cpplint and doxygen checks.

Test it

Focal CI on GitHub actions should return green.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from caguero as a code owner March 11, 2022 22:33
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #298 (bf9f624) into ign-transport8 (07ec13a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head bf9f624 differs from pull request most recent head 3c23f78. Consider uploading reports for the commit 3c23f78 to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-transport8     #298   +/-   ##
===============================================
  Coverage           83.81%   83.81%           
===============================================
  Files                  51       51           
  Lines                5034     5035    +1     
===============================================
+ Hits                 4219     4220    +1     
  Misses                815      815           
Impacted Files Coverage Δ
include/ignition/transport/AdvertiseOptions.hh 100.00% <ø> (ø)
include/ignition/transport/Publisher.hh 100.00% <ø> (ø)
include/ignition/transport/RepHandler.hh 85.36% <ø> (ø)
log/include/ignition/transport/log/QueryOptions.hh 100.00% <ø> (ø)
include/ignition/transport/ReqHandler.hh 80.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ec13a...3c23f78. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina enabled auto-merge (squash) March 14, 2022 22:19
@chapulina chapulina merged commit 788905f into ign-transport8 Mar 14, 2022
@chapulina chapulina deleted the chapulina/8/ci_checks branch March 14, 2022 23:33
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants