NetUtils: simplify logic in determineInterfaces #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preferred_ip array is initialized to {0} and no code
writes to it; it is only read from, so just remove it.
Signed-off-by: Steve Peters <[email protected]>
Each branch executes the same code, so just run that code unconditionally. Signed-off-by: Steve Peters <[email protected]>
The poll() API with integer timeout is deprecated. Use std::chrono::duration instead. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-transport10 #257 +/- ##
===================================================
+ Coverage 89.08% 89.10% +0.02%
===================================================
Files 51 51
Lines 4772 4765 -7
===================================================
- Hits 4251 4246 -5
+ Misses 521 519 -2
Continue to review full report at Codecov.
|
nkoenig
approved these changes
Oct 18, 2021
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Removes an unused variable and simplifies complex logic in
determineInterfacesmethod.Summary
preferred_iparray is initialized to{0}and no code writes to it; it is only read from, so just remove it.I believe this is functionally equivalent to the current code.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge