Consider all network interfaces when checking HOST option.

[caguero]

Signed-off-by: Carlos Agüero [email protected]

🦟 Bug fix

Fixes the following issue:

One publisher sets IGN_IP to 127.0.0.1 and advertises a topic with Scope_T::Host. With these settings, a default subscriber is unable to receive any messages.

Summary

The problem was that we were only checking if the source IP received was matching the host address used by the receiver. Now, we're checking if the source IP received matches any of the network interfaces or localhost.

To test (from the examples directory:

Terminal 1: IGN_IP=127.0.0.1 ./publisher
Terminal 2: ./subscriber

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• [] All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[peci1]

Thanks, it works. I tested both the simple example and a more complex one with the comms model visualization service in SubT.

I have just one comment to the implementation: 127.0.0.1 is not the only localhost address. It's actually 127.255.255.255/8 that's reserved for loopback devices.

[caguero]

Thanks, it works. I tested both the simple example and a more complex one with the comms model visualization service in SubT.

I have just one comment to the implementation: 127.0.0.1 is not the only localhost address. It's actually 127.255.255.255/8 that's reserved for loopback devices.

What do you suggest? Anything that starts with 127. should be considered localhost?

[peci1]

Yes, that's my suggestion.

[caguero]

Yes, that's my suggestion.

Sure, updated in fc1c7da.

[mjcarroll]

Is there any need to make this also work for ipv6?

[peci1]

not from my view, but generally it would be good

[caguero]

Probably out of scope for now.