Fix requester oneway example.

[caguero]

Signed-off-by: Carlos Agüero [email protected]

🦟 Bug fix

It fixes one of the examples from the services tutorial.

Summary

To test:

• Run responser_oneway in one terminal.
• Run requester_oneway in another terminal. You should see the next message in the responser terminal:

Request received: [HELLO]

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #

Summary

Test it

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

➡️ Forward port

Port <FROM_BRANCH> to <TO_BRANCH>

Branch comparison: https://github.com/ignitionrobotics//compare/<TO_BRANCH>...<FROM_BRANCH>

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎈 Release

Preparation for <X.Y.Z> release.

Comparison to <x.y.z>: https://github.com/ignitionrobotics//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>

Needed by <PR(s)>

Checklist

• Asked team if this is a good time for a release
• There are no changes to be ported from the previous major version
• No PRs targeted at this major version are close to getting in
• Bumped minor for new features, patch for bug fixes
• Updated changelog
• Updated migration guide (as needed)
• Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #233 (f7fe4a7) into main (a93722c) will not change coverage.
The diff coverage is n/a.

❗ Current head f7fe4a7 differs from pull request most recent head 7cfbc75. Consider uploading reports for the commit 7cfbc75 to get more accurate results

@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   89.07%   89.07%           
=======================================
  Files          49       49           
  Lines        4678     4678           
=======================================
  Hits         4167     4167           
  Misses        511      511           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93722c...7cfbc75. Read the comment docs.

[adlarkin]

Should we also update the code snippet in the tutorial to match these changes? (https://github.com/ignitionrobotics/ign-transport/blob/fix_oneway_example/tutorials/05_services.md#oneway-requester)

[adlarkin]

Also, in the Building the code section of the tutorial, can we add a note that users should make a msgs directory and then wget the CMakeLists.txt and stringmsg.proto files in the msgs directory?

[caguero]

Should we also update the code snippet in the tutorial to match these changes? (https://github.com/ignitionrobotics/ign-transport/blob/fix_oneway_example/tutorials/05_services.md#oneway-requester)

Good catch! c274828

[caguero]

Also, in the Building the code section of the tutorial, can we add a note that users should make a msgs directory and then wget the CMakeLists.txt and stringmsg.proto files in the msgs directory?

I added it in c274828.

[adlarkin]

Thanks for the updates; feel free to merge!