Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mem leak #174

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Fix mem leak #174

merged 2 commits into from
Sep 11, 2020

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Sep 10, 2020

Fixing a small memory leak that I came across while profiling ign-gazebo. Not sure if sock needs to be closed before that return call though, but since it was being done at the end of the function, I added it before the error-out return call as well.

John Shepherd added 2 commits September 10, 2020 15:24
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
@JShep1 JShep1 requested a review from caguero as a code owner September 10, 2020 22:29
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Sep 10, 2020
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #174 into ign-transport8 will decrease coverage by 0.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-transport8     #174      +/-   ##
==================================================
- Coverage           83.84%   83.41%   -0.44%     
==================================================
  Files                  49       49              
  Lines                5058     4920     -138     
==================================================
- Hits                 4241     4104     -137     
+ Misses                817      816       -1     
Impacted Files Coverage Δ
src/NodeShared.cc 77.95% <0.00%> (-0.31%) ⬇️
log/src/Playback.cc 93.51% <0.00%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd083e3...6b75dad. Read the comment docs.

Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Looks good to me.

@JShep1 JShep1 merged commit a023527 into ign-transport8 Sep 11, 2020
@JShep1 JShep1 deleted the jshep1/fix_mem_leak branch September 11, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants