Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CPPZMQ a PUBLIC dependency #173

Merged
merged 2 commits into from
Sep 5, 2020
Merged

Make CPPZMQ a PUBLIC dependency #173

merged 2 commits into from
Sep 5, 2020

Conversation

joxoby
Copy link
Contributor

@joxoby joxoby commented Sep 4, 2020

zmq.hh is also part of the public API, for example: https://github.com/ignitionrobotics/ign-transport/blob/11c01433aebe1e7377b6e55f49793c226f0bd033/include/ignition/transport/Helpers.hh#L21

Although the fact that zmq.hh is included in the API seems like a bug. @caguero WDYT?

@joxoby joxoby requested a review from caguero as a code owner September 4, 2020 21:46
@chapulina chapulina added the 🔮 dome Ignition Dome label Sep 4, 2020
caguero
caguero approved these changes Sep 5, 2020
View reviewed changes
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The cppzmq header is needed to use the CPPZMQ_VERSION macro.

@caguero caguero merged commit b6e7c38 into gazebosim:master Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joxoby @caguero @chapulina