[fortress] Fix triggered camera test

[scpeters]

🦟 Bug fix

Starts to fix a broken test for triggered cameras

Summary

A test for triggered cameras was added in #194, but it has a few issues.

• It's gtest class name is a duplicate of that from test/integration/camera.cc, so change it to TriggeredCameraTest
• The test was also being skipped on Ubuntu (which uses ogre2 for testing) due to an irrelevant requirement related to segmentation camera sensors.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[scpeters]

the triggered camera test is now failing on both Ubuntu and macOS:

[ RUN      ] CameraSensor/TriggeredCameraTest.ImagesWithBuiltinSDF/ogre2
  [Msg] Loading plugin [ignition-rendering-ogre2]
  [Dbg] [CameraSensor.cc:294] Camera images for [camera1] advertised on [/test/integration/TriggeredCameraPlugin_imagesWithBuiltinSDF]
  [Dbg] [CameraSensor.cc:318] Camera trigger messages for [camera1] subscribed on [__default__/trigger]
  [Dbg] [CameraSensor.cc:591] Camera info for [camera1] advertised on [/test/integration/camera_info]
  /github/workspace/test/integration/triggered_camera.cc:133: Failure
  Value of: helper.WaitForMessage(3s)
    Actual: false
  Expected: true
  [  FAILED  ] CameraSensor/TriggeredCameraTest.ImagesWithBuiltinSDF/ogre2, where GetParam() = "ogre2" (6381 ms)

@WilliamLewww the trigger topic __default__/trigger looks wrong

[WilliamLewww]

Looks like when I merged the <trigger_topic> pull request, the integration test broke from a change in the topic name.

[WilliamLewww]

Once merged, I'll open a forward port [to garden] for this fix.

[codecov]

Codecov Report

Merging #215 (829c03e) into ign-sensors6 (bbdb620) will not change coverage.
The diff coverage is n/a.

❗ Current head 829c03e differs from pull request most recent head 556a7da. Consider uploading reports for the commit 556a7da to get more accurate results

@@              Coverage Diff              @@
##           ign-sensors6     #215   +/-   ##
=============================================
  Coverage         80.00%   80.00%           
=============================================
  Files                 1        1           
  Lines                15       15           
=============================================
  Hits                 12       12           
  Misses                3        3           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdb620...556a7da. Read the comment docs.

[WilliamLewww]

Failing integration tests are unrelated to the triggered camera:

        Start 18: INTEGRATION_depth_camera
  18/45 Test #18: INTEGRATION_depth_camera ................***Exception: SegFault  1.21 sec
        Start 22: INTEGRATION_gpu_lidar_sensor
  22/45 Test #22: INTEGRATION_gpu_lidar_sensor ............***Exception: SegFault  0.80 sec
        Start 24: INTEGRATION_rgbd_camera
  24/45 Test #24: INTEGRATION_rgbd_camera .................***Exception: SegFault  0.91 sec
        Start 26: INTEGRATION_segmentation_camera
  26/45 Test #26: INTEGRATION_segmentation_camera .........***Exception: SegFault  0.75 sec
        Start 28: INTEGRATION_thermal_camera
  28/45 Test #28: INTEGRATION_thermal_camera ..............***Exception: SegFault  0.79 sec

        Start 30: INTEGRATION_triggered_camera
  30/45 Test #30: INTEGRATION_triggered_camera ............   Passed    1.54 sec
        Start 31: check_INTEGRATION_triggered_camera
  31/45 Test #31: check_INTEGRATION_triggered_camera ......   Passed    0.01 sec

[iche033]

changes look good to me. Not sure why tests are failing on Jammy though

[scpeters]

I suppose this fixes it, but it's weird to me that the default trigger topic is __default__/trigger. I think this will need to be fixed in sdformat. I'll take a look at that.

[scpeters]

gazebosim/sdformat#1006

[codecov]

Codecov Report

Merging #215 (4e3e792) into ign-sensors6 (c0495f2) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           ign-sensors6     #215   +/-   ##
=============================================
  Coverage         80.00%   80.00%           
=============================================
  Files                 1        1           
  Lines                15       15           
=============================================
  Hits                 12       12           
  Misses                3        3           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0495f2...4e3e792. Read the comment docs.

[iche033]

Changes look good. The sdformat PR is merged and released (but looks like it does not necessary depend on it after fixing the topic name).

[scpeters]

Changes look good. The sdformat PR is merged and released (but looks like it does not necessary depend on it after fixing the topic name).

correct; I think we can handle the behavior when trigger topic is empty string in a separate PR