Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘©β€πŸŒΎ Disable tests that consistently fail on macOS #121

Merged
merged 4 commits into from
Apr 20, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

See #66 and #67

Summary

These tests are known to fail on macOS consistently. We should disable tests in such cases, so that CI's regular state is green and new test failures are easier to spot.

I opted for just disabling the offending lines instead of the entire test because most of the expectations succeed.

Once this is in, we can make Homebrew CI checks required to merge PRs.

Checklist

  • Signed all commits for DCO
  • Added tests (removed, actually πŸ˜‡ )
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

πŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”Έ

https://github.com/osrf/buildfarmer/issues/181

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added macOS macOS support tests Broken or missing tests / testing infra labels Apr 19, 2021
@chapulina chapulina requested a review from iche033 as a code owner April 19, 2021 22:05
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Apr 19, 2021
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #121 (8c2a952) into ign-sensors3 (2e22200) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-sensors3     #121   +/-   ##
=============================================
  Coverage         77.14%   77.14%           
=============================================
  Files                23       23           
  Lines              2306     2306           
=============================================
  Hits               1779     1779           
  Misses              527      527           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 2e22200...8c2a952. Read the comment docs.

@chapulina
Copy link
Contributor Author

Oh look at that green CI, 15 🟒 checks. A buildfarmer's dream ✨

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 06c9de6 into ign-sensors3 Apr 20, 2021
@chapulina chapulina deleted the chapulina/3/mac_tests branch April 20, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel macOS macOS support tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants