π©βπΎ Disable tests that consistently fail on macOS #121
+18
β0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¦ Bug fix
See #66 and #67
Summary
These tests are known to fail on macOS consistently. We should disable tests in such cases, so that CI's regular state is green and new test failures are easier to spot.
I opted for just disabling the offending lines instead of the entire test because most of the expectations succeed.
Once this is in, we can make Homebrew CI checks required to merge PRs.
Checklist
Updated documentation (as needed)Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
πΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈ
https://github.com/osrf/buildfarmer/issues/181