Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fork experience #94

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Improve fork experience #94

merged 1 commit into from
Oct 21, 2020

Conversation

chapulina
Copy link
Contributor

Our GitHub actions haven't been running correctly for forks. This should fix all of them:

CI

CI only on push means that PRs from forks aren't tested. Adding pull_request fixes forks, with the downside of triggering duplicated jobs for PRs coming from branches in this repo.

Also removed the codecov token for the Focal builds because we only need to upload coverage reports once, and this causes failures sometimes.

And renamed the file to match other libraries, since the file runs for both bionic and focal.

Labeler

Resolves gazebo-tooling/pr-collection-labeler#4.

Uses the new pull_request_target event.

Tested here: gazebosim/testing#14

Triage

Like above, uses the new pull_request_target event.

Tested here: gazebosim/testing#15

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from caguero as a code owner October 14, 2020 21:09
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #94 into ign-msgs5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs5      #94   +/-   ##
==========================================
  Coverage      85.66%   85.66%           
==========================================
  Files              7        7           
  Lines            795      795           
==========================================
  Hits             681      681           
  Misses           114      114           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de7cad7...10f74cd. Read the comment docs.

@chapulina chapulina added the 🏰 citadel Ignition Citadel label Oct 14, 2020
@chapulina chapulina self-assigned this Oct 19, 2020
@chapulina chapulina merged commit 861ea5e into ign-msgs5 Oct 21, 2020
@chapulina chapulina deleted the chapulina/5/forkX branch October 21, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants