Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support colcon in windows CI #189

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Part of gazebo-tooling/release-tools#412

Summary

The windows CI job names are changing due to gazebo-tooling/release-tools#536, so update the windows CI badge in the README. Also, remove configure.bat since it is no longer needed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@scpeters
Copy link
Member Author

new windows job won't work until gazebo-tooling/release-tools#536 is merged

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #189 (c4527b2) into ign-msgs7 (2f2d86e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs7     #189   +/-   ##
==========================================
  Coverage      84.78%   84.78%           
==========================================
  Files              7        7           
  Lines            828      828           
==========================================
  Hits             702      702           
  Misses           126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2d86e...c4527b2. Read the comment docs.

@scpeters scpeters merged commit 7199bfb into gazebosim:ign-msgs7 Oct 14, 2021
@scpeters scpeters deleted the win_colcon_7 branch October 14, 2021 16:15
@chapulina
Copy link
Contributor

Do we need to backport this to Citadel?

@scpeters
Copy link
Member Author

Do we need to backport this to Citadel?

the main thing for the README is that it shows up on the default branch, which is why I targeted ign-msgs7. We are now free to remove configure.bat on Citadel, but it's more cosmetic than functionally required

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants