Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added particle_emitter vector message #149

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 30, 2021

🎉 New feature

Summary

Add a particle_emitter_v message which contains a repeated ParticleEmitter.

This is part of a series of pull requests designed to support particle emitter in gz3d.
See also:

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@nkoenig nkoenig requested a review from caguero as a code owner March 30, 2021 19:55
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #149 (83b50e5) into ign-msgs6 (699e7c3) will not change coverage.
The diff coverage is n/a.

❗ Current head 83b50e5 differs from pull request most recent head 3a9d842. Consider uploading reports for the commit 3a9d842 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs6     #149   +/-   ##
==========================================
  Coverage      84.59%   84.59%           
==========================================
  Files              7        7           
  Lines            818      818           
==========================================
  Hits             692      692           
  Misses           126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699e7c3...3a9d842. Read the comment docs.

@nkoenig nkoenig merged commit 2ecd38c into ign-msgs6 Apr 5, 2021
@nkoenig nkoenig deleted the particle_emitter_v branch April 5, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants