Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added render order to material msgs #118

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 22, 2020

This PR is part of the effort to avoid z-fighting between coplanar meshes.

Related with gazebosim/gz-rendering#188

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde requested a review from iche033 December 22, 2020 13:55
@ahcorde ahcorde self-assigned this Dec 22, 2020
@ahcorde ahcorde requested a review from caguero as a code owner December 22, 2020 13:55
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Dec 22, 2020
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #118 (c34b457) into main (987d226) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files           7        7           
  Lines         818      818           
=======================================
  Hits          692      692           
  Misses        126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987d226...c34b457. Read the comment docs.

@ahcorde ahcorde changed the base branch from ign-msgs6 to main December 22, 2020 18:18
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be retargeted to main, and before it can be used by ign-gazebo, this needs to be done: gazebo-tooling/release-tools#362

@ahcorde ahcorde force-pushed the ahcorde/feature/material_renderorder branch from 9091e98 to fe3b2d9 Compare December 22, 2020 21:11
@ahcorde ahcorde requested a review from chapulina December 22, 2020 21:11
@ahcorde ahcorde force-pushed the ahcorde/feature/material_renderorder branch from fe3b2d9 to fdb439b Compare December 22, 2020 21:19
Signed-off-by: ahcorde <[email protected]>
@chapulina chapulina merged commit 21555dc into main Dec 23, 2020
@chapulina chapulina deleted the ahcorde/feature/material_renderorder branch December 23, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants