Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability for downloading collections #98

Merged
merged 7 commits into from
Aug 13, 2020

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 10, 2020

This PR adds support for downloading collections via ign fuel download. By default it downloads all items in a collection, but a -t option can be given to only download models or worlds in the collection. A -j option can be used to specify the number of parallel downloads.

@azeey azeey requested a review from nkoenig August 10, 2020 20:54
@azeey azeey self-assigned this Aug 10, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have some trivial comments.

include/ignition/fuel_tools/FuelClient.hh Outdated Show resolved Hide resolved
src/cmd/cmdfuel.rb.in Outdated Show resolved Hide resolved
src/ign.cc Show resolved Hide resolved
include/ignition/fuel_tools/CollectionIdentifier.hh Outdated Show resolved Hide resolved
src/cmd/cmdfuel.rb.in Outdated Show resolved Hide resolved
src/ign.cc Show resolved Hide resolved
Copy link
Contributor

@nkoenig nkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, and my comments were minor. Approving.

azeey added 2 commits August 13, 2020 14:54
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey merged commit 2eb0ee7 into gazebosim:ign-fuel-tools3 Aug 13, 2020
@azeey azeey deleted the download_collection branch August 13, 2020 20:50
@chapulina
Copy link
Contributor

👩‍🌾 This PR broke Windows CI. I'm not exactly sure why yet, looking into it.

  • CI without this PR: Build Status
  • With this PR: Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants