Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for annotation parsing during model creation #95

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 5, 2020

Requires: https://gitlab.com/ignitionrobotics/web/fuelserver/-/merge_requests/35

This PR parses the annotations in the fuel metadata, and adds the data to the model's metadata.

Signed-off-by: Nate Koenig [email protected]

@github-actions github-actions bot added the 🔮 dome Ignition Dome label Aug 5, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that the key/value format matches what the server will expect, so this looks good to me.

I know this is difficult to test at the moment, but one idea would be to move the form assembly to a separate function that can at least be unit tested.

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #95 into master will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   75.24%   75.11%   -0.13%     
==========================================
  Files          16       16              
  Lines        2367     2371       +4     
==========================================
  Hits         1781     1781              
- Misses        586      590       +4     
Impacted Files Coverage Δ
src/FuelClient.cc 64.45% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d2e18a...a230629. Read the comment docs.

@nkoenig nkoenig merged commit 9e5bec0 into master Aug 10, 2020
@nkoenig nkoenig deleted the annotations branch August 10, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants