Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport file fetching #84

Merged
merged 6 commits into from
Jul 22, 2020
Merged

Conversation

chapulina
Copy link
Contributor

Backports this PR (released in Citadel), which allows using Fuel URLs within <uri> blocks, among others.

Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #84 into ign-fuel-tools3 will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools3      #84      +/-   ##
===================================================
+ Coverage            85.37%   85.70%   +0.32%     
===================================================
  Files                   16       16              
  Lines                 2017     2028      +11     
===================================================
+ Hits                  1722     1738      +16     
+ Misses                 295      290       -5     
Impacted Files Coverage Δ
src/Interface.cc 88.46% <100.00%> (+28.46%) ⬆️
src/FuelClient.cc 88.13% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3994de3...67616f5. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 56535a2 into ign-fuel-tools3 Jul 22, 2020
@chapulina chapulina deleted the chapulina/3/fetch_files branch July 22, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants