Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document IGN_FUEL_CACHE_PATH on command line #149

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

chapulina
Copy link
Contributor

I always forget what the exact environment variable is. I think we should start documenting all variables on the command line, like ign-gazebo does.

@chapulina chapulina added the documentation Improvements or additions to documentation label Dec 23, 2020
@chapulina chapulina requested a review from nkoenig as a code owner December 23, 2020 02:10
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Dec 23, 2020
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #149 (af10ad3) into ign-fuel-tools4 (21e8b0f) will increase coverage by 1.83%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools4     #149      +/-   ##
===================================================
+ Coverage            78.55%   80.39%   +1.83%     
===================================================
  Files                   19       19              
  Lines                 2583     3269     +686     
===================================================
+ Hits                  2029     2628     +599     
- Misses                 554      641      +87     
Impacted Files Coverage Δ
src/Model.cc 86.66% <0.00%> (-0.84%) ⬇️
src/ModelIter.cc 100.00% <0.00%> (ø)
src/WorldIter.cc 100.00% <0.00%> (ø)
src/LocalCache.cc 82.47% <0.00%> (+2.35%) ⬆️
src/FuelClient.cc 76.08% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e8b0f...af10ad3. Read the comment docs.

@chapulina chapulina force-pushed the chapulina/cache_docs branch from 9e1d558 to af10ad3 Compare December 23, 2020 02:59
@chapulina chapulina changed the base branch from ign-fuel-tools5 to ign-fuel-tools4 December 23, 2020 02:59
@chapulina chapulina added 🏰 citadel Ignition Citadel and removed 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Dec 23, 2020
@chapulina chapulina merged commit 696bf7b into ign-fuel-tools4 Dec 23, 2020
@chapulina chapulina deleted the chapulina/cache_docs branch December 23, 2020 17:31
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants