Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test - Download world 2 #110

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Fixed test - Download world 2 #110

merged 1 commit into from
Aug 25, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 24, 2020

Fixed

  • UNIT_FuelClient_TEST
  • UNIT_ign_src_TEST
  • UNIT_Interface_TEST

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added the tests Broken or missing tests / testing infra label Aug 24, 2020
@ahcorde ahcorde requested a review from chapulina August 24, 2020 09:34
@ahcorde ahcorde requested a review from nkoenig as a code owner August 24, 2020 09:34
@ahcorde ahcorde self-assigned this Aug 24, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #110 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   75.11%   75.07%   -0.05%     
==========================================
  Files          16       16              
  Lines        2371     2371              
==========================================
- Hits         1781     1780       -1     
- Misses        590      591       +1     
Impacted Files Coverage Δ
src/ign.cc 55.58% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbffc09...662ffb4. Read the comment docs.

@ahcorde ahcorde merged commit 5248665 into master Aug 25, 2020
@ahcorde ahcorde deleted the ahcorde/fix/test branch August 25, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants