Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test worlds #100

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Fix test worlds #100

merged 1 commit into from
Aug 12, 2020

Conversation

chapulina
Copy link
Contributor

I uploaded new versions of the test worlds so that they now have both .world (deprecated) and .sdf files. And having a new world version made a bunch of tests fail.

It's unfortunate that the tests need to be updated whenever the worlds are changed, but the hope is that this isn't something we'll do very often 🤞

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from nkoenig as a code owner August 12, 2020 21:07
@chapulina chapulina added the tests Broken or missing tests / testing infra label Aug 12, 2020
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Aug 12, 2020
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #100 into ign-fuel-tools3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-fuel-tools3     #100   +/-   ##
================================================
  Coverage            85.74%   85.74%           
================================================
  Files                   16       16           
  Lines                 2041     2041           
================================================
  Hits                  1750     1750           
  Misses                 291      291           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b291a1...15b5605. Read the comment docs.

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is unfortunate. Same thing happened in #98. Maybe down the road we can add a function that returns the latest version directory.

@chapulina chapulina merged commit b03cce2 into ign-fuel-tools3 Aug 12, 2020
@chapulina chapulina deleted the chapulina/update_test_world branch August 12, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants