Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fuel backend] Support downloading a model #13

Closed
osrf-migration opened this issue Jul 14, 2017 · 2 comments
Closed

[Fuel backend] Support downloading a model #13

osrf-migration opened this issue Jul 14, 2017 · 2 comments
Labels
bug Something isn't working

Comments

@osrf-migration
Copy link

Original report (archived issue) by Shane Loretz (Bitbucket: Shane Loretz, GitHub: sloretz).


Model::Fetch() has a mostly empty implementation. It should download a model from the fuel server if that model doesn't already exist on disk. Saving to disk would require implementing LocalCache::SaveModel and making sure Model has access to the FuelClient instance of LocalCache.

In order to make it possible to test the library with a mock REST class, ModelPrivate must be given an instance of REST and LocalCache classes from FuelClient, which may be difficult. The instances might have to pass through ModelIter or LocalCache when so they can be given to created Model instances.

@osrf-migration
Copy link
Author

Original comment by Shane Loretz (Bitbucket: Shane Loretz, GitHub: sloretz).


  • Edited issue description

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 15, 2020
@chapulina chapulina removed the major label May 26, 2020
@chapulina
Copy link
Contributor

ign fuel download --url https://fuel.ignitionrobotics.org/1.0/openrobotics/models/Ambulance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants