Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Another try at OGRE2.1/OGRE2.2 on Windows" #178

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

mjcarroll
Copy link
Contributor

Reverts #177

This broke CI against OGRE 2.1

@mjcarroll mjcarroll self-assigned this Aug 19, 2021
@mjcarroll mjcarroll requested a review from chapulina August 19, 2021 00:14
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Aug 19, 2021
@mjcarroll mjcarroll mentioned this pull request Aug 19, 2021
@chapulina
Copy link
Contributor

Let's get this in to fix downstream CI and work on a fix that satisfies both 2.1 and 2.2 (without breaking 1.X 😅 )

@chapulina chapulina enabled auto-merge (squash) August 19, 2021 00:32
@chapulina chapulina merged commit db063aa into ign-cmake2 Aug 19, 2021
@chapulina chapulina deleted the revert-177-ogre22_win_again branch August 19, 2021 02:24
srmainwaring pushed a commit to srmainwaring/gz-cmake that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants