Added port & release to PR templates #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenn Nguyen <[email protected]>
github-actions
bot
added
🏢 edifice
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
adlarkin
reviewed
Feb 12, 2021
There was a problem hiding this comment.
Looks pretty good to me! The one thing I have noticed is that the formatting is a little odd on some of the PRs I have seen using the current templates (a few things in the checklist are scattered across multiple lines). I've attached an image below to show an example (the last three items are scattered across multiple lines). I think that we can fix this by making all of the text for every checklist item be on the same line (I left a comment below that helps better illustrate an example).
Signed-off-by: Jenn Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.