Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Marshaler with Codec to mimic CosmosSDK patterns. #3641

Closed
fmorency opened this issue Sep 1, 2023 · 1 comment · Fixed by #3658
Closed

Replace Marshaler with Codec to mimic CosmosSDK patterns. #3641

fmorency opened this issue Sep 1, 2023 · 1 comment · Fixed by #3658
Assignees
Labels
type:bug Something isn't working
Milestone

Comments

@fmorency
Copy link

fmorency commented Sep 1, 2023

Describe the bug
I was playing with the Rosetta 1 integration and realized there is a params/encoding.go discrepancy between Ignite and CosmosSDK.

The EncodingConfig struct found in ignite/templates/app/files/app/params/encoding.go.plush should be changed from

type EncodingConfig struct {
	InterfaceRegistry types.InterfaceRegistry
	Marshaler         codec.Codec
	TxConfig          client.TxConfig
	Amino             *codec.LegacyAmino
}

to

type EncodingConfig struct {
	InterfaceRegistry types.InterfaceRegistry
	Codec             codec.Codec
	TxConfig          client.TxConfig
	Amino             *codec.LegacyAmino
}

to match the CosmosSDK pattern.

Relates cosmos/cosmos-sdk#17608

What version are you using?
Ignite CLI version: v0.27.1
Ignite CLI build date: 2023-06-13T13:42:09Z
Ignite CLI source hash: 4acd1f1
Ignite CLI config version: v1
Cosmos SDK version: v0.47.3
Your OS: linux
Your arch: amd64
Your Node.js version: v18.16.1
Your go version: go version go1.21.0 linux/amd64
Your uname -a: Linux lemurpro 5.10.192-1-MANJARO #1 SMP PREEMPT Sat Aug 26 20:45:34 UTC 2023 x86_64 GNU/Linux
Your cwd: /home/fmorency
Is on Gitpod: false

@fmorency fmorency added the type:bug Something isn't working label Sep 1, 2023
@Ehsan-saradar Ehsan-saradar self-assigned this Sep 12, 2023
@Ehsan-saradar
Copy link
Contributor

Thank you for reporting this issue, @fmorency 🙌

I appreciate you bringing this discrepancy to our attention. I've reviewed the problem, and you're absolutely right. To align with the CosmosSDK pattern, we need to make the change you've suggested in the EncodingConfig struct.

I'm currently working on a new pull request to address this issue, and I'll keep you updated on its progress. If you have any additional insights or suggestions related to this, please feel free to share them.

Once again, thank you for your contribution to the project! 🚀

@Pantani Pantani added this to the v0.28 milestone Sep 25, 2023
@Ehsan-saradar Ehsan-saradar moved this from Todo to In Review in Ignite CLI Masterboard Sep 26, 2023
@Pantani Pantani moved this from In Review to Done in Ignite CLI Masterboard Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants