-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Updating With Private Github Repo #19
Comments
electron-userland/electron-builder#1370
If you mean that your user will somehow use credentials to update, then yes, you need custom server. Use headers to pass auth data. Or you can investigate if authenticated s3 suitable for you and file issue to support it. |
Thanks for the quick response @develar ! So, I actually got it to work where auto updater detects there is an update available, but then fails to actually download it. Does this mean the authentication with Github is working, or there is still something going wrong? I got the auth with private repo to work by using the This is the error I see when using
I'm wondering if this is still an issue with Github authenticating, or if it is a completely separate issue with autoUpdater I'm experiencing. |
Update: I got auto-updating working with simple HTTP request over amazon S3. I never did get auto-updater to work with private Github repos. If someone has a solution I'm still curious to see it, but otherwise this thread can be closed, thanks! |
@peterkrieg the author of electron-updater says that private GitHub repos don't work. Glad you got S3 going! |
@peterkrieg @iffy i got this working fine with 2 repos (one private one for source code, and public one with just releases no source code). In the root of my
i just named the repos the same but appended |
@1-14x0r a two-repo setup like this would be ideal for me. is your |
Hello,
First of all, thank you for an excellent repo - this has been very helpful.
I need to have an electron app autoupdate with a private GH repo. (or other means, but has to be private). It looks like this is not so simple to do (example thread here).
Do you recommend pursuing the Github method, or using simple
http-server
(somehow making that private?)Thank you for any help or suggestions!
The text was updated successfully, but these errors were encountered: