Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

development mode and build mode instrument result is different in normal web project #89

Closed
calmzhuang opened this issue Mar 31, 2023 · 3 comments
Closed

development mode and build mode instrument result is different in normal web project #89

calmzhuang opened this issue Mar 31, 2023 · 3 comments

Comments

@calmzhuang
Copy link

calmzhuang commented Mar 31, 2023 •
edited
Loading

Describe the bug

development mode and build mode instrument result is different in normal web project
development mode：
image

build mode：
image

Binaries:
node: v14.18.2
npm: 6.14.15
vite-plugin-istanbul:4.0.1
Browsers:
Chromium (111.0.5563.110)

Used Package Manager
npm

Logs
No response
@lipanlowdpr
Copy link

#96

@hugo-daclon hugo-daclon mentioned this issue Feb 14, 2024
Merged
iFaxity added a commit that referenced this issue Feb 17, 2024
@hugo-daclon @iFaxity
fix: add regex for vue SFC to prevent instrumenting style and templat…
c8a7ca7 
…es (#180)

* fix: add regex for vue SFC to prevent instrumenting style and templates

Single file Components no longer have their html or css instrumented instead of their script

Closes #96 #178 #89

* build: add prepare script to build the package when using a git version

See https://stackoverflow.com/a/57829251

* build: fix dependencies' vulnerabilities

run npm audit fix

* build: bump devDependencies (patch version only)

* fix: instrument both option and composition API

* style: fix sonarlint issues

* revert: reverted changes to dependencies and package.json

Refs: 1e67efc, ea8fa18, 614a88a

* style: changed to single quotes for strings

---------

Co-authored-by: Hugo <[email protected]>
Co-authored-by: Christian Norrman <[email protected]>
@iFaxity
Copy link
Owner

iFaxity commented Feb 17, 2024

Hi @calmzhuang,

Could you please try the new rc version released with #180 if this fixes your issue?
If there is no problem a release with this will come out to stable within a couple of days.

@iFaxity
Copy link
Owner

iFaxity commented Feb 17, 2024

Closing until this conversation gets picked up again.

@iFaxity iFaxity closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iFaxity @calmzhuang @lipanlowdpr