Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result/version.err is out of sync with release #6

Closed
rjsparks opened this issue Apr 6, 2022 · 0 comments · Fixed by #24
Closed

Result/version.err is out of sync with release #6

rjsparks opened this issue Apr 6, 2022 · 0 comments · Fixed by #24

Comments

@rjsparks
Copy link
Member

rjsparks commented Apr 6, 2022

Having the output of version captured in source-control this way is strange - premise of test needs to be reconsidered.

If we keep this file in source-control, the version of svgcheck itself needs to be updated as part of release.

It would probably be better to compute the desired result at test runtime, given that we have rfctools_common>=0.6.0 in requirements.txt. An update of that package would cause the tests of this one to start failing...

We should also move to using constraints.txt and use that and svgcheck.init.py as the source for the computation for the expected output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant