Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare ThermalStorageTestData for Storage without storageVolumeLvlMin #895

Merged
merged 11 commits into from
Sep 17, 2024

Conversation

danielfeismann
Copy link
Member

@danielfeismann danielfeismann commented Aug 8, 2024

resolves #894

merge this one short before merging #879
merge this one short before merging #860

@danielfeismann danielfeismann self-assigned this Aug 8, 2024
@danielfeismann danielfeismann added the test Issues related to (unit) tests label Aug 8, 2024
@danielfeismann danielfeismann marked this pull request as ready for review August 8, 2024 16:41
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@danielfeismann danielfeismann merged commit 476ec84 into dev Sep 17, 2024
4 checks passed
@danielfeismann danielfeismann deleted the df/#894-storage-zeroLvl branch September 17, 2024 09:11
@danielfeismann
Copy link
Member Author

'ChpModelSpec' and 'CylindricalThermalStorageSpec' also need adaptions for Storage without storageVolumeLvlMin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues related to (unit) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare ThermalStorageTestData for Storage without storageVolumeLvlMin
2 participants