Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have ChpModel make use of the new model states #515

Open
danielfeismann opened this issue Apr 27, 2023 · 1 comment · May be fixed by #516
Open

Have ChpModel make use of the new model states #515

danielfeismann opened this issue Apr 27, 2023 · 1 comment · May be fixed by #516
Labels
code quality Code readability or efficiency is improved enhancement New feature or request

Comments

@danielfeismann
Copy link
Member

I noticed that the HpModel calls calculateNextState in the method calculateActivePower while the ChpModel doesn't. Since both are supposed to stateful maybe that should happen the same way in both models?

Originally posted by @t-ober in #82 (comment)
@danielfeismann danielfeismann self-assigned this Apr 27, 2023
@danielfeismann danielfeismann added the enhancement New feature or request label Apr 27, 2023
This was referenced Apr 27, 2023
Merged
Open
@danielfeismann danielfeismann added code quality Code readability or efficiency is improved and removed enhancement New feature or request labels Apr 27, 2023
@danielfeismann danielfeismann added the wontfix This will not be worked on label May 17, 2023
@danielfeismann danielfeismann removed their assignment Jun 26, 2023
@sebastian-peter sebastian-peter changed the title Align calculate nextState in HpModel and ChpModel Have ChpModel make use of the new model states Jan 31, 2024
@sebastian-peter sebastian-peter removed the wontfix This will not be worked on label Jan 31, 2024
@sebastian-peter
Copy link
Member

I think the underlying problem is that ChpModel makes use of the mutable state of MutableStorage, while it should be converted to use ThermalStorageState like HpModel does. After solving this, MutableStorage and related deprecated functionality should be removed.
So to me, this issue is valid, although currently not at a high prio.

@sebastian-peter sebastian-peter added the enhancement New feature or request label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Code readability or efficiency is improved enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align determination of nextState at ChpModel and HpModel ie3-institute/simona
2 participants
@sebastian-peter @danielfeismann