Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider PrimaryData that start before simulation #1034

Open
staudtMarius opened this issue Nov 19, 2024 · 1 comment · May be fixed by #1038
Open

Consider PrimaryData that start before simulation #1034

staudtMarius opened this issue Nov 19, 2024 · 1 comment · May be fixed by #1038
Assignees
@staudtMarius
Labels
enhancement New feature or request

Comments

@staudtMarius
Copy link
Member

One point to discuss, based on the data in vn_simona: Asuming I would increase the simulation start time by one hour from '2011-01-01T00:00:00Z' to 2011-01-01T01:00:00Z, this would cause the exception because time series 8c04e94e-76b0-4369-a55c-f5e1117fb83e has no entry for 01:00:00. But with our general approach we define values as valid until a new one at a certain tick arrise. In my humble opinion this case would be vaild, while some earlier start date (e.g. 2010-12-31T23:00:00Z') wouldn't.

Originally posted by @danielfeismann in #1016 (comment)
@staudtMarius staudtMarius self-assigned this Nov 19, 2024
@staudtMarius staudtMarius added the enhancement New feature or request label Nov 19, 2024
@sebastian-peter
Copy link
Member

I agree. Also linking the post with my thoughts: #1016 (review)

This was referenced Nov 20, 2024
Open
Draft
staudtMarius added a commit that referenced this issue Nov 20, 2024
@staudtMarius
Merge branch 'dev' into ms/#1034-consider-PrimaryData-that-start-befo…
b18ab34 
…re-simulation
staudtMarius added a commit that referenced this issue Nov 22, 2024
@staudtMarius
Merge branch 'dev' into ms/#1034-consider-PrimaryData-that-start-befo…
e06ea1a 
…re-simulation
staudtMarius added a commit that referenced this issue Nov 26, 2024
@staudtMarius
Merge branch 'dev' into ms/#1034-consider-PrimaryData-that-start-befo…
31f2106 
…re-simulation

# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/service/primary/PrimaryServiceWorker.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staudtMarius staudtMarius

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Considering primary data that start before simulation. ie3-institute/simona
2 participants
@sebastian-peter @staudtMarius