Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idris crashes in ide-mode when asked to make a with clause #4549

Open
justjoheinz opened this issue Sep 4, 2018 · 2 comments
Open

Idris crashes in ide-mode when asked to make a with clause #4549

justjoheinz opened this issue Sep 4, 2018 · 2 comments

Comments

@justjoheinz
Copy link
Contributor

Steps to Reproduce

given the following program (running atom):

module Main

main : IO ()
main = putStrLn "Hello"
(*)

place the cursor in the empty line marked with (*) and ask idris to insert a with clause. Atom will send a request with an empty word.

Expected Behavior

Even when sending a wrong request to idris in ide-mode it should probably reply with a reasonable error message

Observed Behavior

Idris crashes.

The fix in Atom is simple enough, one just has to make sure that the command is not send when the word under the cursor is empty. However I think this is still a bug, as idris should simply not crash.

@bukzor
Copy link

bukzor commented Sep 8, 2018

Here's the mentioned fix: idris-hackers/atom-language-idris@c98aabd

@justjoheinz
Copy link
Contributor Author

The same applies to make case statements. idris crashes when the send word is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants