Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs with trailing / make the tests fail #5

Closed
Yannick-Dayer opened this issue Aug 9, 2024 · 0 comments · Fixed by #6
Closed

URLs with trailing / make the tests fail #5

Yannick-Dayer opened this issue Aug 9, 2024 · 0 comments · Fixed by #6
Assignees

Comments

@Yannick-Dayer
Copy link
Collaborator

Turns out the fix in #4 was not enough, as the actual URLs passed to sphinx come from Catalog and most URLs will contain a / at then end.

Apparently sphinx >= 8.0 appends /objects.inv at the end of the URL, resulting in double /.
The error is corrected by sphinx later on so it still works:

loading intersphinx inventory 'numpy' from https://numpy.org/doc/stable//objects.inv ...
intersphinx inventory has moved: https://www.sphinx-doc.org/en/master//objects.inv -> https://www.sphinx-doc.org/en/master/objects.inv

But our tests only look at the loading intersphinx inventory line so they fail.

Either we ask sphinx to revert to the same behavior as before, we add a check to remove the trailing / at the end of every URL in Catalog, or we change the tests to allow the //.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant