Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with the latest versions of sphinx #3

Closed
Yannick-Dayer opened this issue Aug 7, 2024 · 2 comments · Fixed by #4
Closed

Tests fail with the latest versions of sphinx #3

Yannick-Dayer opened this issue Aug 7, 2024 · 2 comments · Fixed by #4
Assignees

Comments

@Yannick-Dayer
Copy link
Collaborator

auto-intersphinx tests work with sphinx=7.4 but fail with sphinx=8.0

@Yannick-Dayer Yannick-Dayer self-assigned this Aug 7, 2024
@Yannick-Dayer
Copy link
Collaborator Author

Ah, it seems to be an issue with the output of sphinx. Here is an output that we fail to parse:

Running Sphinx v8.0.2                                                                                                                                                                          
loading translations [en]... done                                                                                                                                                              
making output directory... done                                                                                                                                                                
Converting `source_suffix = '.rst'` to `source_suffix = {'.rst': 'restructuredtext'}`.                                                                                                         
loading intersphinx inventory 'python' from https://docs.python.org/3.10//objects.inv ...                                                                                                      
loading intersphinx inventory 'numpy' from https://numpy.org/doc/stable//objects.inv ...                                                                                                       
building [mo]: all of 0 po files
[...]

The culprit is the // before the objects.inv in the URLs. The URL itself is still valid so it's not that critical for Sphinx, but as we compare stdout in our tests, it does not match exactly.

I'll fix the tests to not look a the end of the URL.

@Yannick-Dayer
Copy link
Collaborator Author

It's actually us that give that "malformed" URL to sphinx in the first place.
I found where it was and am fixing it.

No idea why sphinx cleaned the URL before sphinx 8.0 but not after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant