Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input format on witness generation #380

Open
damesca opened this issue Jun 6, 2023 · 0 comments
Open

Input format on witness generation #380

damesca opened this issue Jun 6, 2023 · 0 comments

Comments

@damesca
Copy link

damesca commented Jun 6, 2023

I have found a detail concerning the input data for witness generation.

There are two ways to enter numbers:
(1) as json numbers, e.g., "a": 1234,
(2) as json strings, e.g., "a": "1234".

Both ways work fine with small numbers, but when the input is a bigint, it must be passed in string format, otherwise precision is lost and the input is internally modified, leading to incorrect results.

It would be a useful detail for newcomers to have this specified in the README, in section 14 ("calculate the witness").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant