From 836e668e9e1cbede85a42658b4a8f8d3622a18fd Mon Sep 17 00:00:00 2001 From: Charlie Parker Date: Mon, 5 Aug 2024 12:28:08 -0400 Subject: [PATCH] bs4 fix dependent spousal validation (#4194) * fix dependent check * fix rubocop error on updated function --- .../app/models/financial_assistance/applicant.rb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/components/financial_assistance/app/models/financial_assistance/applicant.rb b/components/financial_assistance/app/models/financial_assistance/applicant.rb index 37a3237c8ba..69ced281c39 100644 --- a/components/financial_assistance/app/models/financial_assistance/applicant.rb +++ b/components/financial_assistance/app/models/financial_assistance/applicant.rb @@ -621,12 +621,11 @@ def invalid_family_relationships def invalid_spousal_relationship partner_relationships = application.relationships.where({ "$or" => [ - { :applicant_id => id, :kind.in => ['spouse', 'domestic_partner'] }, - { :relative_id => id, :kind.in => ['spouse', 'domestic_partner'] } + { :applicant_id => id, :kind.in => ['spouse', 'domestic_partner'] }, + { :relative_id => id, :kind.in => ['spouse', 'domestic_partner'] } ] }) - partner_relationships_for_applicant = partner_relationships.filter { |relationship| relationship.applicant_id == id } - return partner_relationships_for_applicant.drop(1) if partner_relationships_for_applicant.present? + return partner_relationships.drop(1) if partner_relationships.size > 2 end def invalid_sibling_relationship