Nonlocal cracktip material #29576

lynnmunday · 2024-12-19T01:08:13Z

…or at crack tip

… and output

…ck tip. The lower k critical causes the crack to grow one element deeper into the bulk material in the minus x direction

…aholab#29575

…ngle value

moosebuild · 2024-12-19T03:36:21Z

Job Documentation, step Docs: sync website on ad6bdcc wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2024-12-19T22:59:56Z

Job Conda (Rocky) on 3740102 : invalidated by @lynnmunday

moosebuild · 2024-12-19T23:58:34Z

Job OpenMPI on 3740102 : invalidated by @lynnmunday

moosebuild · 2024-12-19T23:59:34Z

Job Test HPC on 3740102 : invalidated by @lynnmunday

lynnmunday · 2024-12-20T00:54:18Z

@bwspenc Will you review?

moosebuild · 2024-12-20T01:18:41Z

Job Coverage, step Generate coverage on ad6bdcc wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Solid mechanics

	2974c5	#29576 ad6bdc
	Total	Total	+/-	New
Rate	84.95%	84.96%	+0.01%	91.84%
Hits	28318	28341	+23	90
Misses	5015	5017	+2	8

Diff coverage report

Full coverage report

Xfem

	2974c5	#29576 ad6bdc
	Total	Total	+/-	New
Rate	82.38%	82.37%	-0.01%	91.18%
Hits	6907	6916	+9	31
Misses	1477	1480	+3	3

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

…nt Kcrit or kcrit from vpp crack growth. Added error checking and testing for these options.

moosebuild · 2024-12-23T17:36:48Z

All jobs on 22a9519 : invalidated by @lynnmunday

bwspenc · 2024-12-20T23:02:50Z

modules/solid_mechanics/doc/content/source/vectorpostprocessors/CrackFrontNonlocalScalar.md

@@ -0,0 +1,19 @@
+# CrackFrontNonlocalScalar


Maybe something like CrackFrontNonlocalScalarMaterial would be more descriptive?

bwspenc · 2024-12-20T23:04:27Z

modules/solid_mechanics/doc/content/source/vectorpostprocessors/CrackFrontNonlocalScalar.md

+
+## Description
+
+This object computes the average scalar material property at the crack front points defined by  [CrackFrontDefinition.md].  The main use case for this `VectorPostprocessor` is to compute an average fracture toughness or $k_crit$ at the crack front for use with the `MeshCut2DFractureUserObject` to grow cracks. This allows for spatially varying $k_crit$ values defined by a `Material`.


Suggested change

This object computes the average scalar material property at the crack front points defined by [CrackFrontDefinition.md]. The main use case for this `VectorPostprocessor` is to compute an average fracture toughness or $k_crit$ at the crack front for use with the `MeshCut2DFractureUserObject` to grow cracks. This allows for spatially varying $k_crit$ values defined by a `Material`.

This object computes the average of a scalar material property over regions ahead of the crack tip, as defined by the front points obtained from [CrackFrontDefinition.md]. The main use cases for this `VectorPostprocessor` is to compute an average fracture toughness or $k_crit$ at the crack front for use with the `MeshCut2DFractureUserObject` to grow cracks, but this can be used for other scalar material properties as well. This allows for spatially varying $k_crit$ values defined by a `Material`.

modules/solid_mechanics/doc/content/source/vectorpostprocessors/CrackFrontNonlocalStress.md

modules/solid_mechanics/include/vectorpostprocessors/CrackFrontNonlocalMaterialBase.h

modules/solid_mechanics/include/vectorpostprocessors/CrackFrontNonlocalStress.h

modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalMaterialBase.C

modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalStress.C

modules/xfem/src/userobjects/MeshCut2DFractureUserObject.C

modules/xfem/test/tests/mesh_cut_2D_fracture/edge_crack_2d_propagation.i

Co-authored-by: Ben Spencer <[email protected]>

moosebuild · 2024-12-23T21:47:27Z

Job Precheck, step Clang format on 91b45b9 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/29576/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 2974c54c5269c9b763547954236d33e3a55a8710

moosebuild · 2024-12-30T16:40:40Z

All jobs on 4b6d396 : invalidated by @lynnmunday

…daholab#29575

moosebuild · 2025-01-02T16:43:46Z

Job OpenMPI on ad6bdcc : invalidated by @lynnmunday

moosebuild · 2025-01-02T16:53:13Z

Job Test HPC on ad6bdcc : invalidated by @lynnmunday

moosebuild · 2025-01-02T17:53:26Z

Job Test HPC on ad6bdcc : invalidated by @lynnmunday

moosebuild · 2025-01-02T21:53:03Z

Job Test HPC on ad6bdcc : invalidated by @lynnmunday

lynnmunday · 2025-01-02T22:39:14Z

@bwspenc Will you review this again and merge?

dschwen · 2025-01-11T18:59:29Z

modules/solid_mechanics/include/vectorpostprocessors/CrackFrontNonlocalMaterialBase.h

+/**
+ * Computes the average material property in regions near points provided by the
+ * crack_front_definition vectorpostprocessor.
+ */
+


Suggested change

/**

* Computes the average material property in regions near points provided by the

* crack_front_definition vectorpostprocessor.

*/

/**

* Computes the average material property in regions near points provided by the

* crack_front_definition vectorpostprocessor.

*/

dschwen · 2025-01-11T19:00:23Z

modules/solid_mechanics/include/vectorpostprocessors/CrackFrontNonlocalScalarMaterial.h

+  CrackFrontNonlocalScalarMaterial(const InputParameters & parameters);
+
+protected:
+  /// The scalar material property


Suggested change

/// The scalar material property

/// Property that is averaged over the crack front points

dschwen · 2025-01-11T19:00:41Z

modules/solid_mechanics/include/vectorpostprocessors/CrackFrontNonlocalStress.h

 */
-class CrackFrontNonlocalStress : public ElementVectorPostprocessor
+


Suggested change

dschwen · 2025-01-11T19:01:40Z

modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalMaterialBase.C

+  : ElementVectorPostprocessor(parameters),
+    _property_name(property_name),
+    _box_length(getParam<Real>("box_length")),
+    _box_width(isParamValid("box_width") ? getParam<Real>("box_width") : 1),


Why not default that parameter to 1.0?

dschwen · 2025-01-11T19:02:31Z

modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalMaterialBase.C

+CrackFrontNonlocalMaterialBase::execute()
+{
+  // icfp crack front point index
+  for (std::size_t icfp = 0; icfp < _avg_crack_tip_scalar.size(); icfp++)


Suggested change

for (std::size_t icfp = 0; icfp < _avg_crack_tip_scalar.size(); icfp++)

for (const auto icfp: index_range(_avg_crack_tip_scalar))

dschwen · 2025-01-11T19:03:57Z

modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalMaterialBase.C

+  gatherSum(_avg_crack_tip_scalar);
+  gatherSum(_volume);
+
+  for (std::size_t icfp = 0; icfp < _avg_crack_tip_scalar.size(); ++icfp)


index_range

dschwen · 2025-01-11T19:04:13Z

modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalMaterialBase.C

+{
+  const auto & uo = static_cast<const CrackFrontNonlocalMaterialBase &>(y);
+
+  for (auto i = beginIndex(_avg_crack_tip_scalar); i < _avg_crack_tip_scalar.size(); ++i)


index_range etc.

dschwen · 2025-01-11T19:04:57Z

modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalMaterialBase.C

+  Real q = 0.0;
+  if ((crack_node_to_current_node_rot(0) > 0) &&
+      (crack_node_to_current_node_rot(0) <= _box_length) &&
+      (std::abs(crack_node_to_current_node_rot(1)) <= _box_height / 2) &&
+      (std::abs(crack_node_to_current_node_rot(2)) <= _box_width / 2))
+  {
+    q = 1.0;
+  }
+
+  return q;


Suggested change

Real q = 0.0;

if ((crack_node_to_current_node_rot(0) > 0) &&

(crack_node_to_current_node_rot(0) <= _box_length) &&

(std::abs(crack_node_to_current_node_rot(1)) <= _box_height / 2) &&

(std::abs(crack_node_to_current_node_rot(2)) <= _box_width / 2))

{

q = 1.0;

}

return q;

if ((crack_node_to_current_node_rot(0) > 0) &&

(crack_node_to_current_node_rot(0) <= _box_length) &&

(std::abs(crack_node_to_current_node_rot(1)) <= _box_height / 2) &&

(std::abs(crack_node_to_current_node_rot(2)) <= _box_width / 2))

return 1.0;

return 0.0;

lynnmunday added 7 commits December 18, 2024 14:50

Creating base class for nonlocal material averaged vector postprocess…

2e89488

…or at crack tip

adding scalar material output at crack tip

5f0f10e

fixing tests for changes to CrackFrontNonlocalStress vpp input format…

1adaba9

… and output

adding k_critical_vpp to MeshCut2D object

407b5fa

adding k_critical_material and vpp to sample this material at the cra…

ab7fe50

…ck tip. The lower k critical causes the crack to grow one element deeper into the bulk material in the minus x direction

adding test for CrackFrontNonlocalScalar to solid_mechanics closes id…

8903f82

…aholab#29575

adding parameter error if kcritical is defined with both a vpp and si…

21d16da

…ngle value

lynnmunday requested review from bwspenc, jiangwen84 and dschwen as code owners December 19, 2024 01:08

lynnmunday added 3 commits December 19, 2024 09:27

clean up function signatures and doxygen

908a049

adding documentation

ac56eb7

removed paramWarning that caused tests to fail

3740102

moosebuild added the PR: Failed but allowed label Dec 20, 2024

GiudGiud assigned bwspenc Dec 20, 2024

lynnmunday marked this pull request as draft December 20, 2024 16:41

moosebuild removed the PR: Failed but allowed label Dec 20, 2024

lynnmunday marked this pull request as ready for review December 20, 2024 21:28

lynnmunday force-pushed the nonlocal_cracktip_matl branch 2 times, most recently from 8da5e53 to 81f8043 Compare December 20, 2024 22:51

Fixing MeshCut2DFractureUserObject to use just stress based or consta…

22a9519

…nt Kcrit or kcrit from vpp crack growth. Added error checking and testing for these options.

lynnmunday force-pushed the nonlocal_cracktip_matl branch from 81f8043 to 22a9519 Compare December 23, 2024 17:18

bwspenc requested changes Dec 23, 2024

View reviewed changes

lynnmunday and others added 2 commits December 23, 2024 12:53

Apply suggestions from code review

dfffda7

Co-authored-by: Ben Spencer <[email protected]>

addressing user comments about name change

78c7bb5

lynnmunday force-pushed the nonlocal_cracktip_matl branch from ed48de3 to 91b45b9 Compare December 23, 2024 21:42

lynnmunday force-pushed the nonlocal_cracktip_matl branch 2 times, most recently from 1c83119 to 4b6d396 Compare December 23, 2024 22:01

lynnmunday force-pushed the nonlocal_cracktip_matl branch 3 times, most recently from c7bdcd9 to 4512c85 Compare December 31, 2024 15:17

Daniel helped me move the property name to the derived class. closes i…

ad6bdcc

…daholab#29575

lynnmunday force-pushed the nonlocal_cracktip_matl branch from 4512c85 to ad6bdcc Compare January 2, 2025 00:49

moosebuild added the PR: Failed but allowed label Jan 2, 2025

dschwen reviewed Jan 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nonlocal cracktip material #29576

Nonlocal cracktip material #29576

lynnmunday commented Dec 19, 2024

moosebuild commented Dec 19, 2024 •

edited

Loading

moosebuild commented Dec 19, 2024

moosebuild commented Dec 19, 2024

moosebuild commented Dec 19, 2024

lynnmunday commented Dec 20, 2024

moosebuild commented Dec 20, 2024 •

edited

Loading

moosebuild commented Dec 23, 2024

bwspenc Dec 20, 2024

lynnmunday Dec 23, 2024

bwspenc Dec 20, 2024

moosebuild commented Dec 23, 2024

moosebuild commented Dec 30, 2024

moosebuild commented Jan 2, 2025

moosebuild commented Jan 2, 2025

moosebuild commented Jan 2, 2025

moosebuild commented Jan 2, 2025

lynnmunday commented Jan 2, 2025

dschwen Jan 11, 2025

dschwen Jan 11, 2025

dschwen Jan 11, 2025

dschwen Jan 11, 2025

dschwen Jan 11, 2025 •

edited

Loading

dschwen Jan 11, 2025

dschwen Jan 11, 2025

dschwen Jan 11, 2025


		## Description

		This object computes the average scalar material property at the crack front points defined by [CrackFrontDefinition.md]. The main use case for this `VectorPostprocessor` is to compute an average fracture toughness or $k_crit$ at the crack front for use with the `MeshCut2DFractureUserObject` to grow cracks. This allows for spatially varying $k_crit$ values defined by a `Material`.

	/// The scalar material property
	/// Property that is averaged over the crack front points

		*/
		class CrackFrontNonlocalStress : public ElementVectorPostprocessor

	for (std::size_t icfp = 0; icfp < _avg_crack_tip_scalar.size(); icfp++)
	for (const auto icfp: index_range(_avg_crack_tip_scalar))

Nonlocal cracktip material #29576

Are you sure you want to change the base?

Nonlocal cracktip material #29576

Conversation

lynnmunday commented Dec 19, 2024

moosebuild commented Dec 19, 2024 • edited Loading

moosebuild commented Dec 19, 2024

moosebuild commented Dec 19, 2024

moosebuild commented Dec 19, 2024

lynnmunday commented Dec 20, 2024

moosebuild commented Dec 20, 2024 • edited Loading

Framework coverage

Modules coverage

Solid mechanics

Xfem

Full coverage reports

moosebuild commented Dec 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moosebuild commented Dec 23, 2024

moosebuild commented Dec 30, 2024

moosebuild commented Jan 2, 2025

moosebuild commented Jan 2, 2025

moosebuild commented Jan 2, 2025

moosebuild commented Jan 2, 2025

lynnmunday commented Jan 2, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dschwen Jan 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moosebuild commented Dec 19, 2024 •

edited

Loading

moosebuild commented Dec 20, 2024 •

edited

Loading

dschwen Jan 11, 2025 •

edited

Loading