Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material strings can become unruly. #144

Open
MicahGale opened this issue Mar 8, 2023 · 9 comments · May be fixed by #608
Open

Material strings can become unruly. #144

MicahGale opened this issue Mar 8, 2023 · 9 comments · May be fixed by #608
Assignees
Labels
feature request An issue that improves the user interface.
Milestone

Comments

@MicahGale
Copy link
Collaborator

When you print a material a list of all its elements are included. For depleted fuel this can become ... very unruly. Should implement a numpy style snip that cuts out a lot of the middle bits.

@MicahGale
Copy link
Collaborator Author

In addition the elements should be sorted by composition. It's hard for anyone but a materials scientist to see that: 'magnesium', 'aluminum', 'silicon', 'chromium', 'manganese', 'iron', 'copper', 'zinc', 'tin' is aluminum-6061.

@MicahGale
Copy link
Collaborator Author

I keep coming back: and really wanting the composition sorting.

@SterlingButters
Copy link

In addition the elements should be sorted by composition. It's hard for anyone but a materials scientist to see that: 'magnesium', 'aluminum', 'silicon', 'chromium', 'manganese', 'iron', 'copper', 'zinc', 'tin' is aluminum-6061.

Should again consider #344 (comment) for material labeling (not necessarily the sorting)

@MicahGale
Copy link
Collaborator Author

To clarify this isn't about writing to file this is just for printing when examining a material:

print(material)

@SterlingButters
Copy link

SterlingButters commented Feb 6, 2024

I'm a little surprised that MCNP doesn't support named materials - or do they? If, so, could just be on the user to do so. If not, you could still leverage the JSONification for this (imo).

@MicahGale
Copy link
Collaborator Author

Do you mean by being able to label m1 as water or being able to define a material as being water?

@SterlingButters
Copy link

@MicahGale I feel like either would resolve the issue right? But AFAICT, there isn't any native way to do this in MCNP.

@MicahGale
Copy link
Collaborator Author

Yes you are right, neither of these features is supported by MCNP natively, much to everyone's chagrin.

So next steps on your idea: I think all of these would be a separate issue:

  1. Extend the scope of Add named Cells #76.
  2. Add common composition data (at least elemental) data to simplify generating new materials. I am warry of doing this as we would then be responsible for a rather large data set. Though people can't sue us over getting it wrong, they can still complain loudly.

@SterlingButters
Copy link

2. Add common composition data (at least elemental) data to simplify generating new materials. I am warry of doing this as we would then be responsible for a rather large data set. Though people can't sue us over getting it wrong, they can still complain loudly.

Honestly, I don't think it will be long before people request the PNNL Material Compendium anyhow

@MicahGale MicahGale mentioned this issue Sep 4, 2024
35 tasks
@MicahGale MicahGale self-assigned this Sep 4, 2024
@MicahGale MicahGale modified the milestones: Release-0.3, 1.0.0-alpha Nov 8, 2024
@MicahGale MicahGale linked a pull request Dec 5, 2024 that will close this issue
21 tasks
@MicahGale MicahGale modified the milestones: 1.0.0-alpha, M&C workshop Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request An issue that improves the user interface.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants