Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: can not use logging with bool #69

Closed
icyleaf opened this issue May 27, 2019 · 0 comments · Fixed by #70
Closed

Bug: can not use logging with bool #69

icyleaf opened this issue May 27, 2019 · 0 comments · Fixed by #70
Labels

Comments

@icyleaf
Copy link
Owner

icyleaf commented May 27, 2019

Halite.logging(true).get("...")

# Or
Halite::Client.new
  logging true
end

It returns:

in src/halite/chainable.cr:390: no overload matches 'Halite::Options#with_logging' with types Bool, file: Nil, filemode: String, skip_request_body: Bool, skip_response_body: Bool, skip_benchmark: Bool, colorize: Bool
Overloads are:
 - Halite::Options#with_logging(format : String, **opts)
 - Halite::Options#with_logging(logging : Halite::Logging::Abstract)

This effected only in Crystal 0.28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant