Don't call CleanName from the ZipEntry constructor. #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piksel
approved these changes
Dec 31, 2019
|
Hi! |
|
I don't know what the plans for the next release are, but you could maybe look at the CI builds if you need a build of it? |
Oh I didn't notice that it's already available in pr. Thank you once again! :) |
piksel
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #341 - don't call CleanName in the ZipEntry constructor.
This matches the doc comments on one of the ZipEntry constructors which says that the name format isn't enforced anyway. Not sure if this causes any gaps where names won't be validated on creating zips - not sure whether it'd be better to do some validation for 'new' ZipEntries, but just not for ones created internally when reading an existing zip?
Also marked as WIP because on further testing it seems that a lot of the validation for the characters in paths has been removed from .NET Core, meaning that the exception described in #341 might only happen in the full version of .NET (and as the unit tests are only built as Core, the exception won't be seen there).
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.