Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding error may fail FastZip access time test #600

Closed
piksel opened this issue Mar 14, 2021 · 0 comments · Fixed by #601
Closed

Rounding error may fail FastZip access time test #600

piksel opened this issue Mar 14, 2021 · 0 comments · Fixed by #601

Comments

@piksel
Copy link
Member

piksel commented Mar 14, 2021

When running tests, CreateZipShouldSetTimeOnEntriesFromConstructorTimeSetting(LastAccessTime) might fail due to a rounding error (or it could be due to the time difference between when the test is getting the time and the file actually being updated).
In any case, what the test is actually trying to determine, is if the time is updated, not how accurate it is. Adding a +/- 2s tolerance should fix it.

Expected behavior

Test should pass regardless of what time its being executed.

Actual behavior

  Error Message:
     Expected: 2021-03-14 14:23:42
  But was:  2021-03-14 14:23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant