Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastZip closes not owned stream in method CreateZip #124

Closed
7 tasks
TalyCraft opened this issue Jul 14, 2016 · 3 comments
Closed
7 tasks

FastZip closes not owned stream in method CreateZip #124

TalyCraft opened this issue Jul 14, 2016 · 3 comments
Assignees
Labels
bug zip Related to ZIP file format

Comments

@TalyCraft
Copy link

TalyCraft commented Jul 14, 2016

Steps to reproduce

  1. Download and install latest nuget package
  2. Initialize new FastZip and new MemoryStrram
  3. Call method CreateZip with created MemoryStream as argument

Expected behavior

MemoryStream instance is filled with data and is in operable state, not disposed

Actual behavior

MemoryStream instance was disposed after control returned from CreateZip method

Version of SharpZipLib

SharpZipLib.0.86.0

Obtained from (place an x between the brackets for all that apply)

  • Compiled from source
    • branch: _______
    • commit: _______
  • Downloaded DLL from GitHub
  • Downloaded DLL from SourceForge
  • Downloaded DLL from _______
  • DLL included as part of
  • Package installed using:
    • [x ] NuGet
    • MyGet
    • Chocolatey
@ghost
Copy link

ghost commented Aug 8, 2016

Is this the NuGet packet you're using: https://www.nuget.org/packages/SharpZipLib/ ? Note that it is way out of date with respect to the GitHub sources.

@McNeight McNeight self-assigned this Aug 14, 2016
@McNeight McNeight added bug zip Related to ZIP file format and removed bug labels Aug 14, 2016
@Numpsy
Copy link
Contributor

Numpsy commented Apr 22, 2020

Can this be closed as a dup of #78?

@piksel
Copy link
Member

piksel commented May 28, 2020

Yeah!

@piksel piksel closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug zip Related to ZIP file format
Projects
None yet
Development

No branches or pull requests

3 participants