Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for 0.3.0 release #98

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Conversation

mikeskydev
Copy link
Member

Tidy up readme, update version numbers

@mikeskydev mikeskydev requested review from andybak and mikeage April 12, 2021 22:45
Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! When you merge this, you'll get a 0.2.30 build on main, but after you push the v0.3 tag to main (on the squashed merge commit), it'll build 0.3.0 and create the release in github. (hopefully ;-) )

@mikeskydev
Copy link
Member Author

Thanks for checking, and reminding me which tag I need to make! Will add the GitHub sponsors link and squash.

@mikeskydev mikeskydev removed the request for review from andybak April 13, 2021 12:01
@mikeskydev mikeskydev merged commit 19bee24 into icosa-foundation:main Apr 13, 2021
@mikeskydev mikeskydev deleted the release/0.3 branch April 13, 2021 12:10
@mikeskydev
Copy link
Member Author

@mikeage so close! Looks like it didn't pull the full changelog since 0.2?

@mikeage
Copy link
Member

mikeage commented Apr 13, 2021

Hmmm... did you update the changelog? What's there now looks perfect... I can check the logs from the action

@mikeskydev
Copy link
Member Author

Yes, I've brought in from all the other changelogs manually, it just had the single most recent change before

@mikeage
Copy link
Member

mikeage commented Apr 13, 2021

Gotcha. It looks like this test wasn't correct:

if [ $(git describe --tags --abbrev=0) == $(git describe --tags) ]
then
    PREV=$(git describe --tags --abbrev=0 HEAD^)
else
    PREV=$(git describe --tags --abbrev=0)
fi

I'll check why in a little bit (going home now). Sorry about that!

@mikeage
Copy link
Member

mikeage commented Apr 13, 2021

Oh, duh, of course. I copy pasted the wrong thing when I finally merge this. Will fix soon.

@mikeage
Copy link
Member

mikeage commented Apr 14, 2021

Fixed in #101 (along with a bit of duplicate code removed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants