Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Poly panel fix #91

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Conversation

mikeskydev
Copy link
Member

Checks for the panel existing before disabling. d'oh.

Sidenote, why doesn't m_NotSupportedMessage?.SetActive(false); work here?

Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working! Thanks

@mikeage mikeage mentioned this pull request Apr 10, 2021
@mikeage
Copy link
Member

mikeage commented Apr 10, 2021

I'm going to merge this one, hope there are no objections

@mikeage mikeage merged commit 107447d into icosa-foundation:main Apr 10, 2021
@TimAidley
Copy link
Contributor

@mikeskydev, the reason m_NotSupportedMessage?.SetActive(false); doesn't work is that m_NotSupportedMessage points to a UnityEngine.Object-derived type, which means that it is a wrapper around a C++ object in the Unity Engine. As a result, C++ is in charge of its lifetime, rather than C#. Now, because C++ is in charge of lifetime, an object in C++ may get destroyed, while a reference to it still exists in C#.

To make this 'simpler', Unity set UnityEngine.Object so that if you test equality with null when the C++ object has been destroyed, it will return true. Most of the time this works fine, but it does mean that null coalescing operators don't work because a Unity object that we think of as null may actually not be null, but pointing to a destroyed object.

@mikeage
Copy link
Member

mikeage commented Apr 10, 2021

That is a really helpful explanation, thank you!

@mikeskydev
Copy link
Member Author

Yeah that explains a lot, thanks!

@mikeskydev mikeskydev deleted the fix/poly-panel branch April 10, 2021 21:11
mikeskydev added a commit to mikeskydev/open-brush that referenced this pull request Jul 4, 2021
With Poly shutting down, we can remove these temporary messages
@mikeskydev mikeskydev mentioned this pull request Jul 4, 2021
andybak pushed a commit that referenced this pull request Jul 12, 2021
* revert #86 and #91

With Poly shutting down, we can remove these temporary messages

* Disable Poly, but not GDrive

* remove mention of poly in accounts window

* fix formatting
andybak added a commit to IxxyXR/open-brush that referenced this pull request Dec 8, 2021
* revert icosa-foundation#86 and icosa-foundation#91

With Poly shutting down, we can remove these temporary messages

* Disable Poly, but not GDrive

* remove mention of poly in accounts window

* fix formatting
@andybak andybak mentioned this pull request Dec 8, 2021
andybak added a commit that referenced this pull request Dec 9, 2021
* revert #86 and #91

With Poly shutting down, we can remove these temporary messages

* Disable Poly, but not GDrive

* remove mention of poly in accounts window

* fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants