Documentation and gulp deps
#2
Conversation
|
@pramodjodhani Please can you add some screenshots/video for what this PR is doing? |
|
@jamesckemp Done. |
There was a problem hiding this comment.
I was unable to test because after compiling the plugin using gulp compile I got this error. Is the composer vendor folder required?
Warning: require_once(/chroot/home/4yS2nPI8/vivaciouspanther.build067.wpsandbox.app/html/wp-content/plugins/iconic-wds-google-calendar/vendor/autoload.php): failed to open stream: No such file or directory in /chroot/home/4yS2nPI8/vivaciouspanther.build067.wpsandbox.app/html/wp-content/plugins/iconic-wds-google-calendar/iconic-wds-google-calendar.php on line 121 Fatal error: require_once(): Failed opening required '/chroot/home/4yS2nPI8/vivaciouspanther.build067.wpsandbox.app/html/wp-content/plugins/iconic-wds-google-calendar/vendor/autoload.php' (include_path='.:/opt/remi/php74/root/usr/share/pear:/opt/remi/php74/root/usr/share/php:/usr/share/pear:/usr/share/php') in /chroot/home/4yS2nPI8/vivaciouspanther.build067.wpsandbox.app/html/wp-content/plugins/iconic-wds-google-calendar/iconic-wds-google-calendar.php on line 121 Notice: Function is_embed was called incorrectly. Conditional query tags do not work before the query is run. Before then, they always return false. Please see [Debugging in WordPress](https://wordpress.org/support/article/debugging-in-wordpress/) for more information. (This message was added in version 3.1.0.) in /chroot/home/4yS2nPI8/vivaciouspanther.build067.wpsandbox.app/html/wp-includes/functions.php on line 5831 Notice: Function is_search was called incorrectly. Conditional query tags do not work before the query is run. Before then, they always return false. Please see [Debugging in WordPress](https://wordpress.org/support/article/debugging-in-wordpress/) for more information. (This message was added in version 3.1.0.) in /chroot/home/4yS2nPI8/vivaciouspanther.build067.wpsandbox.app/html/wp-includes/functions.php on line 5831
|
FYI, I updated this to use the Gulp 4 branch. You may need to clear node_modules and rerun npm |
|
@jamesckemp It should be fixed now. Please feel free to check. |
|
Can we fix the alignment here? What happens if the addon is activated and Delivery Slots is not? Do we add a notice about requiring the core plugin? |
iconic-wds-google-calendar.php
Outdated
| } | ||
| ?> | ||
| <div class="notice notice-error is-dismissible"> | ||
| <p><?php esc_html_e( 'Google Calendar Addon for WooCommerce Delivery Slots requires the WooCommerce Delivery Slots to be installed and activated.' ); ?></p> |
There was a problem hiding this comment.
We should link to the plugin with UTMs as well
source = iconic
medium = plugin
campaign = iconic-wds-gcal
You also need textdomain here
There was a problem hiding this comment.
Sure @jamesckemp. This is done.
For the alignment issue of the link icon, please can you check this PR? iconicwp/WordPress-Settings-Framework#89
|
@pramodjodhani The notice is dismissable, but it isn't persistent. We should just make it not dismissable. |
|
Sure @jamesckemp , this is done. |
|
Pending a docs update so I can test 😓 |
|
@jamesckemp I have updated the doc. Please feel free to test again. |
|
Yep, works perfectly! |
|
I'll leave the merge to you. |
Video
General working
wds-google-calendar.mp4
Fixes #1
This is done.
Not done yet, I have added an issue here: iconicwp/WordPress-Settings-Framework#80
This is also done. We will also need to merge this PR for this to work: iconicwp/WordPress-Settings-Framework#79