Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update] Auto select the tab if the tab ID is present in the URL hash #79

Merged
merged 3 commits into from
May 25, 2022
Merged

[update] Auto select the tab if the tab ID is present in the URL hash #79

merged 3 commits into from
May 25, 2022

Conversation

pramodjodhani
Copy link
Collaborator

@pramodjodhani pramodjodhani commented May 13, 2022 •
edited
Loading

auto-select-tab.mp4

@pramodjodhani pramodjodhani requested a review from jamesckemp May 13, 2022 07:13
@pramodjodhani pramodjodhani mentioned this pull request May 13, 2022
Merged
jamesckemp
jamesckemp approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@jamesckemp jamesckemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, just remove the line you mentioned and merge

@pramodjodhani
Copy link
Collaborator Author

Thanks @jamesckemp

@pramodjodhani pramodjodhani merged commit 71aae62 into master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesckemp jamesckemp jamesckemp approved these changes

Assignees

@pramodjodhani pramodjodhani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pramodjodhani @jamesckemp