Timezone setting is not documented

[bildlich]

Overview

One of the examples in the Readme contains the timezone setting -e TZ=America/Los_Angeles but not reference how to use this setting.

In my case, this lead to me not using the setting, which gave me the warning /usr/lib/python3.8/site-packages/tzlocal/unix.py:158: UserWarning: Can not find any timezone configuration, defaulting to UTC. warnings.warn('Can not find any timezone configuration, defaulting to UTC.')

Steps to Reproduce

1. On a synology NAS, mount docker image with $ sudo docker pull icloudpd/icloudpd
2. Create folders to store photos and cookie
3. Run docker run -it --rm --name icloud \ -v myPath:/data \ -v myPath/cookies:/cookies \ icloudpd/icloudpd:latest \ icloudpd --directory /data \ --cookie-directory /cookies \ --folder-structure {:%Y%m%d} \ --username [iCloud username] \ --password [iCloud Password] \ --size original \ --recent 3 \ --auto-delete
4. Perform 2FA
5. Download starts. Get the warning /usr/lib/python3.8/site-packages/tzlocal/unix.py:158: UserWarning: Can not find any timezone configuration, defaulting to UTC. warnings.warn('Can not find any timezone configuration, defaulting to UTC.')
6. The files are successfully downloaded. It's unclear what the effect of the timezone configuration would have been.

Expected Behavior

• The Readme says what the setting does, and what possible values are
• The warning says what "defaulting to UTC" means in practice

Actual Behavior

See above

Context

Steps were taken on a Synology NAS via SSH from a Mac. The files seem to copy correctly. I can't verify if anything funky happened to the creation date and time of the photo.

[menkej]

I'm not using docker so I can't reproduce. Seems like some info for timezones is missing from the base image. This is happening in other docker linux images as well. See p.e. here: jfloff/alpine-python#50

It's not really a bug, just a warning. But as far as I understand it can be solved by adding/configuring tzdata to the base image. So we probably have to add the following in Dockerfile.release

apk add tzdata
RUN ln -fs /usr/share/zoneinfo/Etc/UTC /etc/localtime

Maybe I find some time to try this out this weekend.

[boredazfcuk]

I install tzdata in my Docker image and then start the container with the TZ variable to get rid of this warning.

IIRC it needs to know the time zone because it is required to calculate timestamps, presumably a dependency of the set-exif-datetime capability.

[menkej]

Pull request #289 is already there. Thanks for confirming my research, @boredazfcuk !

[menkej]

fixed with #289

[bildlich]

Thank you!

[N7l-00]

F