Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIDO] 2FA doesn't work when FIDO Security Key is enabled #583

Open
maxromanovsky opened this issue Feb 12, 2023 · 12 comments
Open

[FIDO] 2FA doesn't work when FIDO Security Key is enabled #583

maxromanovsky opened this issue Feb 12, 2023 · 12 comments

Comments

@maxromanovsky
Copy link

Overview

2FA doesn't work when Security Key is enabled

Steps to Reproduce

  1. Enable FIDO key as 2FA on iCloud account
  2. Run icloudpd --recent=1 -u [email protected] -d tmp
  3. Choose SMS or TOTP as 2FA

Expected Behavior

2FA works with the FIDO key or there is an error message that FIDO is unsupported

Actual Behavior

  • Error if SMS is selected as 2FA
  • App hangs if TOTP is selected as 2FA

SMS = Error:

2023-02-12 10:42:22 DEBUG    Authenticating...
iCloud Password:
2023-02-12 10:42:27 INFO     Two-step/two-factor authentication is required!
  0: SMS to *******XX
  1: Enter two-factor authentication code
Please choose an option: [0]: 0
2023-02-12 10:42:30 ERROR    Failed to send two-factor authentication code

TOTP = hangs forever:

iCloud Password:
2023-02-12 10:37:08 INFO     Two-step/two-factor authentication is required!
  0: SMS to *******XX
  1: Enter two-factor authentication code
Please choose an option: [0]: 1
Please enter two-factor authentication code: ^CAborted!

Context

@maxromanovsky maxromanovsky changed the title 2FA doesn't work when Security Key is enabled 2FA doesn't work when FIDO Security Key is enabled Feb 15, 2023
@ChiefGyk3D
Copy link

I've been able to replicate this issue as well in my docker running on my NAS

@AndreyNikiforov
Copy link
Collaborator

@maxromanovsky @ChiefGyk3D can you try entering code generated by Security Key Device at the "Please enter two-factor authentication code" prompt, please?

@lawrence-forooghian
Copy link

@AndreyNikiforov What code do you mean? Are you thinking of a TOTP code, such as that generated by an app like Google Authenticator? That’s not how FIDO keys work; the application communicates directly with the security key (over USB or Bluetooth or NFC) and there is no code exposed to the user.

@AndreyNikiforov
Copy link
Collaborator

@AndreyNikiforov What code do you mean? Are you thinking of a TOTP code, such as that generated by an app like Google Authenticator? That’s not how FIDO keys work; the application communicates directly with the security key (over USB or Bluetooth or NFC) and there is no code exposed to the user.

My experience is limited to Yubi Leave-in key (not linked to iCloud). If I have an entry field in focus and touch the key, it spits characters (as if it is a keyboard). If the same behavior is true for other keys that are used (no matter of communication technology), then it should be trivial to test if that stream of generated characters from the device registered with iCloud works out of the box. That was the test I asked for, sorry for confusion.

@lawrence-forooghian
Copy link

lawrence-forooghian commented Mar 3, 2023

Ah, I see – you're talking about Yubico OTP, in which the Yubikey appears to the computer as a keyboard. That's different to the FIDO standard used by iCloud, which has its own protocol defining the communication between device and security key, and in which the key does not appear to the computer as a keyboard.

@lawrence-forooghian
Copy link

(Unlike Yubico OTP, FIDO requires two-way communication between the computer and security key, which means that the fix for this will be more involved than simply getting some input from the user.)

@ChiefGyk3D
Copy link

@maxromanovsky @ChiefGyk3D can you try entering code generated by Security Key Device at the "Please enter two-factor authentication code" prompt, please?

There is no "code" to enter when it comes to the FIDO standard. That's what makes it more secure, it has to communicate with our USB keys in a two way fashion.

FIDO is becoming standardized across the industry Apple, Microsoft, and many other companies are using it. There are libraries to pass it through in Linux and more. I am even using a FIDO login to get into this GitHub for years. https://fidoalliance.org/how-fido-works/

@iain-henderson
Copy link

It does seem that Yubico provides a Python Library
https://github.com/Yubico/python-fido2

@eliliam
Copy link

eliliam commented Jul 18, 2023

I am having the same issue, has there been any development into resolving this? If not, is there a way to use SMS to authenticate? It appears that option 0(SMS code) always errors out when you have configured FIDO security keys.

@AndreyNikiforov
Copy link
Collaborator

I am having the same issue, has there been any development into resolving this? If not, is there a way to use SMS to authenticate? It appears that option 0(SMS code) always errors out when you have configured FIDO security keys.

Can you use SMS for web login to icloud.com? icloudpd just simulates web access, so if SMS is blocked for web access once you add fido, then I don't see a way to have icloudpd working for that account.

@gmemstr
Copy link

gmemstr commented Sep 11, 2023

Yeah, it does block SMS, or any other kind of 2FA, for web access. Apple's security key implementation is also pretty half-baked, and will complain if you're using anything other than Safari or Chrome.

@AndreyNikiforov
Copy link
Collaborator

FIDO is not supported. changing bug to enhancement

@AndreyNikiforov AndreyNikiforov changed the title 2FA doesn't work when FIDO Security Key is enabled [FIDO] 2FA doesn't work when FIDO Security Key is enabled Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants