Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate our usage of str, String, etc. in slicec-cs API #3926

Closed
InsertCreativityHere opened this issue Feb 13, 2024 · 1 comment
Closed

Re-evaluate our usage of str, String, etc. in slicec-cs API #3926

InsertCreativityHere opened this issue Feb 13, 2024 · 1 comment
Labels
cleanup slice-cs code generator
Milestone
Future

Comments

@InsertCreativityHere
Copy link
Member

We have a variety of function signatures ranging from simple &str to T: ToString to impl Into<String>.
We should look through our API surface and see if these types could be improved (for greater flexibility on the calling side),
or simplified in cases where it's use is limited.

See #3925 (comment)
Merged
@InsertCreativityHere InsertCreativityHere added this to the Future milestone Feb 13, 2024
@InsertCreativityHere
Copy link
Member Author

The distinction between str and String is specific to Rust.
Since the eventual goal is to port slicec-cs to C# (#3978), there's no point in these Rust-specific improvements.

@InsertCreativityHere InsertCreativityHere closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup slice-cs code generator
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@InsertCreativityHere