net/proxy/ares unuse dynamic array as not supported by msvc

iceboy233 · Dec 22, 2023 · 21d377e · 21d377e
1 parent f70c7d7
commit 21d377e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/net/proxy/ares/resolver.cc b/net/proxy/ares/resolver.cc
@@ -96,7 +96,7 @@ void Resolver::wait() {
 }
 
 void Resolver::set_servers(absl::Span<const Endpoint> servers) {
-    ares_addr_port_node nodes[servers.size()];
+    auto nodes = std::make_unique<ares_addr_port_node[]>(servers.size());
     for (size_t i = 0; i < servers.size(); ++i) {
         nodes[i].next = i + 1 < servers.size() ? &nodes[i + 1] : nullptr;
         const address &address = servers[i].address();
@@ -114,7 +114,7 @@ void Resolver::set_servers(absl::Span<const Endpoint> servers) {
         nodes[i].udp_port = servers[i].port();
         nodes[i].tcp_port = servers[i].port();
     }
-    if (ares_set_servers_ports(channel_, nodes) != ARES_SUCCESS) {
+    if (ares_set_servers_ports(channel_, nodes.get()) != ARES_SUCCESS) {
         abort();
     }
 }

diff --git a/net/tools/ares-resolve.cc b/net/tools/ares-resolve.cc
@@ -18,7 +18,8 @@ int main(int argc, char *argv[]) {
     io_context io_context;
     auto executor = io_context.get_executor();
     proxy::system::Connector connector(executor, {});
-    BlockingResult<std::error_code, std::vector<address>> results[argc - 1];
+    auto results = std::make_unique<
+        BlockingResult<std::error_code, std::vector<address>>[]>(argc - 1);
     for (int i = 1; i < argc; ++i) {
         connector.resolver().resolve(argv[i], results[i - 1].callback());
     }